Oleg Andreyev

Results 116 comments of Oleg Andreyev

> Thanks for your PR! > > I'm not sure if this is the right approach, I'd like to find out how common this use-case is. The json file is...

Another example: I want to apply \Doctrine\SqlFormatter\SqlFormatter on SQL code from entity, but I don't want to "keep" this code in entity... so another sh*tty workaround ```php yield CodeEditorField::new('executableSelector') ->setHelp('For...

+1 here, I'm +1 to disallow inheritance, keep it `final` but composition is key of OOP, so need to provide an interface so that I could decorate it

Case is mentioned here https://github.com/DamienHarper/auditor/issues/184 and https://github.com/DamienHarper/auditor/blob/8edca5bedfda2f838003471321c60c45d941ba03/src/Provider/Doctrine/Auditing/Event/DoctrineSubscriber.php#L37-L42 this could be a wrong implementation from auditor lib, but it's **OCP**, we decorate connection/driver to add extra functionality - so imo valid...

@phansys please approve workflow.

merged main branch, @phansys @franmomu

https://github.com/doctrine-extensions/DoctrineExtensions/issues/2704#issuecomment-1777435330

related also to https://github.com/DamienHarper/auditor/issues/185