Oleg Andreyev comments

Results 116 comments of


                                            Oleg Andreyev

Added condition to check that we have an active connection

> Can you add a test that reproduces the problem you'd like to fix? It's hard to reproduce this scenario in CI, as we need to boot entire application (without...

Added condition to check that we have an active connection

@derrabus any chance that you'll be able to take a look at this?

Don't update package.json or controllers.json if vendor not updated

this is quite annoying I have `"@hotwired/turbo": "^7.2.2"` and each `composer update` (e.g. resolving conflict after merge) flex is downgrading it to "@hotwired/turbo": "^7.1.0"

ElementToBeClickable doesn't actually guarantee the element is clickable

JFYI Here is Selenium implementation https://github.com/SeleniumHQ/selenium/blob/bf2fc564eeaeecfd980984119bd18d0a00bdb29e/java/client/src/org/openqa/selenium/support/ui/ExpectedConditions.java#L627 and atom implementation https://github.com/SeleniumHQ/selenium/blob/0f197cbd4fa9acdd2ac3ddebbe0cc9b4ca26bff8/javascript/chrome-driver/atoms.js#L220

added test to make sure Firefox profile is working

https://github.com/mozilla/geckodriver/issues/1990

added test to make sure Firefox profile is working

> I refactored the tests and merged them into `FirefoxProfileTest`, as we now already have #961 . Thanks @oleg-andreyev! Sorry, I've some how missed your previous comment. Thanks for handling...

Window API will return Window Rect

Yes, I think this was discussed with @OndraM in PR comments

Window API will return Window Rect

> Yes, I think this was discussed with @OndraM in PR comments To be exact @OndraM added milestone 2.0

Window API will return Window Rect

@OndraM please take a look

Request timeout can be shorter than page timeout

> some webpage, and loading the page takes longer then 30 seconds, you will get Curl error, even if you pageLoad timeout is set to 300 seconds, right? Right. But...