Pete Gonzalez

Results 696 comments of Pete Gonzalez

Here's the PR: https://github.com/microsoft/rushstack/pull/3575

I was able to reproduce the error using your `https://github.com/larshp/mysql` branch, thanks! However, the .d.ts inputs are very weird. The APIs are exported using the ancient `export =` form that...

> I got this as well when setting `"bundledPackages": ["connect"],` in Vite. Using api-extractor version `7.18.5`. Stacktrace refers to the same method (new line number since new version): Even though...

> I'm not sure if that code should be updated though? It seems like a valid thing to do and am not sure how I'd change the actual `senchalabs/connect` package...

Would you be able to share a GitHub branch with your progress so far?

Super helpful, thank you! Looking at your exported API, the only references to the `connect` package seem to be here: [packages/vite/src/node/server/index.ts](https://github.com/benmccann/vite/blob/64692a41a281d9addc8a0d91a1f4357249a68294/packages/vite/src/node/server/index.ts#L193) ```ts export declare interface ViteDevServer { /** * The...

Could you give a little more information about your use case? How would this feature be different from manually deleting the library from **package.json** and then running `rush update` or...

The main benefit of `rush add` is that it (1) figures out the right version number and (2) makes sure it's consistent with other projects across the repo. > *...

> In our monorepo, one of our project teams had a deadline and resolved some emergent issues using a [patch-package](https://www.npmjs.com/package/patch-package) change on a package. As-is, this is not the end...

🎉 @chengcyber has created a PR: https://github.com/microsoft/rushstack/pull/3554