Pete Gonzalez

Results 698 comments of Pete Gonzalez

For this one, looks like Jest is invoking Babel, and then Babel queries `browserslist`: ![image](https://user-images.githubusercontent.com/4673363/138573579-260a9a47-859e-43ed-b76e-53fdec3265f6.png) The query returns an empty array. The [heft-node-jest-tutorial](https://github.com/microsoft/rushstack/tree/master/build-tests-samples/heft-node-jest-tutorial) as no browser configuration itself and would...

For comparison, here's how HBO's internal monorepo invokes `browserslist`: ```ts import browserslist from 'browserslist'; function getTargetsFromQuery(query: string[]): string[] { try { return browserslist(query); } catch (error) { throw new Error(`Browsers...

> This `outdated caniuse-lite` warning is important for building web pages. People can avoid updating `caniuse-lite` for 2-3 years, which will lead to very old browsers in Babel and Autoprefixer...

> We have a problem of falling CI on warnings. It is strange behavior for me since it delete the difference between the error and warning. Rush's difference is very...

> (Also, adding git request will be hard and having git call during Browserslist call will be unexpected for users). Maybe you've misunderstood my proposal. As an extremely simplified example,...

> I have an idea of not showing this warning in case where browsers query doesn't contain time related queries like `last 2 versions`. Agreed -- maybe this ☝ is...

@k8w and @tylerbutler encountered this same issue in #2671

🤔 `@inheritDoc` was originally introduced to support API Documenter, which predates the .d.ts rollup feature. In theory, if your tooling supports TSDoc, it shouldn't matter whether `@inheritDoc` is expanded in...

This problem affects the `rush change` CLI command, not just the API. Let's fix it! 👍

From [#contributor-helpline](https://rushstack.zulipchat.com/#narrow/stream/279883-contributor-helpline/topic/.5Brush-lib.5D.20.233251.20Contribution.20question/near/274512353): > According to the source code, the current file name pattern looks like `your-branch-name_2021-12-09-20-51.json` and its uniqueness is based on the clock time `YYYY-MM-DD-HH-MM`. But it's not unique...