objecttothis

> > > @objecttothis Ok this is really weird, as I showed in the unit test, the decimal rounding works as it should. Can you check the code in between...

A little addendum. I added the precision on my local copy and it didn't fix the issue. I've traced it all the way back to my json_encode statement. I'm going...

Found it: https://stackoverflow.com/questions/42981409/php7-1-json-encode-float-issue/43056278 I wish they would leave things alone. We need to assess how this will affect other aspects of the code. @daN4cat are we generally only using JSON...

> > > @objecttothis I guess this one can be closed? Per your comments on the 24th, I need to make those changes in the code. I assigned myself and...

> Not sure if there is a decimal datatype in javascript. If we want to replicate the exact locale formatting in JSON then maybe it's better to export the field...

I think I'm closer to a fix here but I'm out of time for the day. In the Items controller the saveItemAttributes function is pulling attributeIds for all the attributes...

I think our current process is to do a squash and merge rather than merge the commits without squash. Is that different from what you're asking? I suspect the commits...

@jekkos is the only issue with this PR that the commit history is messy? It seems that the method I'm using for rebasing on the master is causing the messy...

> Ah right I just meant squash the history as it seems this has some duplicate commit messages that are already in master. So if you can squash the old...

It turns out that our only_full_group_by friend has struck again and it isn't an empty result set causing the problem.  The solution here is to separate the queries so...