objecttothis
objecttothis
The issue is not just SQL functions but parenthesis in general. If I add parenthesis to the where() call (such as might be done using the `OR` or `AND` operators...
My initial thought was to parse inside SQL functions. For example, since AVG() expects a column or table.column, to assume that when you come across that in the Select() function...
The sticky spot is going to be not just replacing everything that matches a table or column name since it's very likely for someone to have a table or column...
> I would write such complex queries directly. To clarify, you're saying this counts as complex? ``` $builder = $this->db->table('sales'); $builder->select('AVG(sales_items.discount)'); $selectQuery = $builder->getCompiledSelect(); ```
> I don't think it can be fixed. To handle complex SQL, we would have to add support for more methods to generate the appropriate SQL instead of trying to...
Also, the default rules for this linter change a few standards that we currently have. Are we changing those? For example currently the project uses tabs, but the CS Fixer...
I looked into it a little and the way to customize the rules would be to create a .php_cs.dist file in the root of the project and configure it the...
Also, when I installed cs-fixer it defaulted to PSR-2, but PSR-12 is the current best practice for coding standards rulesets.
> I looked into it a little and the way to customize the rules would be to create a .php_cs.dist file in the root of the project and configure it...
@SteveIreland I just reopened this. Maybe we can close it again, but I'm I'm trying to sort through the issues that @jekkos reported with the database migration failing on new...