Gary Brown

Results 93 comments of Gary Brown
trafficstars

@boskokg @peekpt If the fork is going to be used to create a new plugin name, could I suggest that the fork is moved to a github organization, rather than...

Hi @benmccann Sorry for the very long delay in answering your question. This library does not actually create spans - it is only responsible for propagating the trace context between...

@benmccann Sounds like it could be a useful feature - although probably would need to be configurable and disabled by default, as could bloat the trace instances. Could you create...

Did you deploy zipkin in the istio-system namespace? Have you tried tracing the bookinfo example and seen it working? In Istio, the responsibility for creating tracing data for inbound and...

Hi @JasmithaMeka So just to be clear, you deployed the services in the branch I referenced, and you were able to see traces in the zipkin UI? > I understood...

Hi, From the changes you have described, I can't see why you are not getting any traces (even just from the inbound requests to the proxy) - but if tracing...

Thanks - but why have you submitted every small change as a separate PR? Can you create a single PR that has all of the changes?

You need to fork the repo and create the branch in your own repo - and then submit the PR from there.

It is possible in envoy to configure the health check endpoint, and then it will be ignored by tracing. For example, I updated the [jaeger tracing](https://www.envoyproxy.io/docs/envoy/latest/start/sandboxes/jaeger_tracing) example `front-envoy-jaeger.yaml` to include...

@nixgadget Just wondered, have you tried adding the http header `X-B3-Sampled: 0` to the liveness probe?