Gary Brown

Results 93 comments of Gary Brown
trafficstars

@yurishkuro Agree it would be good to be able to distinguish client and server errors, however I think client errors still need to be recorded in someway on the server...

It wasn't intended to represent a join - just to group the actual spans that represent the processing of the individual messages. I thought a join would be represented by...

The current null return value is currently only useful to enable the code to determine if there is an active (sampled) trace, which it could use to decide whether to...

Good point - but in terms of current situation, I think the only usecase of returning null is to allow code to determine whether a trace is underway (sampled or...

@bhs I think we need to consider batching as a separate issue. But actually like the idea of just using `Follows From` as essentially the relationship type is the same,...

> In my mind the question hinges on whether there are multiple parents. If it's just a linear sequence, I am personally comfortable with an unadorned FOLLOWS_FROM, though it would...

Ok so if we have a new tag, e.g. `'subtrace' = 'true'` (better name required), then it can also be independent of the relationship types used - so could potentially...

@yurishkuro Just wondering if that would be necessary, given the new `asRoot` method being proposed in https://github.com/opentracing/opentracing-java/pull/115 ? Doesn't this imply that, regardless of what references are subsequently added, the...

@yurishkuro Not sure any new boolean attribute is required, as if the `asRoot` method is used the `Span` will automatically be the root of a new trace. Any subsequent references...

Ah ok - I thought `asRoot` may become part of the language independent API. @bhs thoughts?