Nariman Abdullin

Results 99 comments of Nariman Abdullin

GitHub generates alerts, but as security/code-scanning: https://github.com/saveourtool/save-cloud/security/code-scanning?query=is%3Aopen+pr%3A2022 Need to investigate why it not added as comments

Githiub adds `Code scanning` comments only to updated part of code: diktat does detect a location for unused import incorrectly (always 1:1), that why github doesn't show it See: https://github.com/saveourtool/save-cloud/pull/2025...

Need to check that token is a trigger to validate unused imports: probably we use a File instead of `import blabla`, that why location is 1:1

> Anything else? `hr {}` and another `html`'s blocks in frontend apps

hi @sergeypospelov, thanks for raising a bug and a brief investigation. We will look into it

> can you please add a description with links for our future younger generations with the reason of why this change is needed after K2. And link to the Kotlin...

> Finishing it? I guess it requires rewriting `HistoryView.kt` to FC

It's about filtering method: we need to have single method to fetch vulnerabilities instead of several named methods

Need to finish https://github.com/saveourtool/save-cloud/pull/329