Nolan Kramer

Results 25 comments of Nolan Kramer

@jameskerr Looking at the code... is there a reason absolute positioning is used instead of relative/flex layout? It stands to reason that line-items in the tree will never overlap? (although...

To be clear - it looks like this PR adds a boolean toggle to whether a node's widget is displayed in the node or pops-out to a separate window? @zmoth...

This change looks great, is there any additional feedback for the PR author? Or can it be merged?

1. CXXGraph already supports CPM, somewhat, but it's not great: ``` CPMAddPackage("gh:ZigRazor/CXXGraph") if (CXXGraph_ADDED) add_library(CXXGraph INTERFACE IMPORTED GLOBAL) target_include_directories(CXXGraph INTERFACE "${CXXGraph_SOURCE_DIR}/include") endif() ``` In this instance, we will want to...

@Ajay-26 No need to retract the PR. It seems like an unrelated issue. Feel free to ignore it.

I've added some feedback on the PR to point you in the right direction :)

My comments largely reflect @ZigRazor's comments, so mine can be ignored.

Hey @gcampbell-msft, Version is 1.17.17 My project is very large and proprietary - however the repro steps above should be sufficient to repro on that version!

@sbaldu That sounds right to me. Looks like another project solved this recently: https://github.com/Technologicat/pyan/issues/68#issuecomment-852888394 They had contributors post a message "I approve re-licensing my contributions to `` under the ``...