Nolan

Results 18 comments of Nolan
trafficstars

Would love (a version with) this. Still, looks like I have a new default distance calc for my fuzzball package either way! :D (changing the 1's on lines 12 and...

can create a connected component in app root that shows toaster when some value gets updated.

```javascript class RootToaster extends PureComponent { componentDidUpdate(prevProps) { if (this.props.alert && this.props.alert !== prevProps.alert) { this.refs.toast.show(this.props.alert.message); } } render() { return ; } } export const ConnectedRootToaster = connect(({alerts}) =>...

It would change the existing behavior in the case where all of the existing items are removed. If you think of the single item scenario as just a special case...

Currently definition of this function from the comment says "This function takes a previous set of keys and a new set of keys and merges them with its best guess...

Ya I think that would work splendidly. Just trying to think, if, for some reason, you replaced an item in the list with 2 new items, the first one append...

Should work, I think could probably implement it. The "only matters when you remove all keys" part might not apply anymore though, since it could also be used when replacing...

Yup, if you replaced consecutive keys and wanted to interleave the new ones it still wouldn't be able to. Was thinking there could be a 'replacesKey' prop, or go back...

If it's important to have the full control, was thinking there could be a replacesKey prop that would work as an additional hint to appendOnReplace, where if it's replacing a...

Would work. Feel like a top level prop for default direction would solve most people issues without having to re-implement internals themselves, but ya not as flexible. Would be happy...