node-core-utils

node-core-utils copied to clipboard

feat(land): add skipChecks option

4

skipChecks will allow skipping certain checks. Useful to skip "commit after last approval" on commit queue. Ref: https://github.com/nodejs/node/issues/34770

mmarchini

ncu-ci: add commit-v8

2

Opening as draft if someone wants to try it. Still need to run some tests and write some unit tests.

mmarchini

If the pr labels `v8 engine`, run https://ci.nodejs.org/job/node-test-commit-v8-linux/ too.

gengjiawen

There's a pretty decent number of requirements to contribute to node that are easy to fumble. It would be lovely if node-core-utils provided a suite of checks that can be...

bnb

flaky auth tests in CI

1

Example: https://github.com/nodejs/node-core-utils/runs/1987341751?check_suite_focus=true ``` 1) auth asks for auth data if no ncurc is found: Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning...

targos

Fast-track indicator in commit metadata

1

When a pull-request has been fast-tracked, it would likely be good for us to capture that detail in the commit metadata as an FYI. I'm thinking something simple like: ```...

jasnell

Don't require full CI when `.github/` is the only change (and others)

1

This might also require policy changes on `nodejs/node`, but for PRs changing Actions we don't need to run full CI. Same goes for PRs changing CODEOWNERS, or linter rules, among...

mmarchini

Changes to PR wait time and approval checks

1

If https://github.com/nodejs/node/pull/33879 lands the checks should be changed to: - Require only one approval by default - Recommend (without blocking) to wait for a second approval - Drop wait times...

mmarchini

If last CI is still running, `git node land --yes` should fail

1

`git node land --yes` checks will succeed and advance if last CI is still running, which opens the door for landing PRs before we get a result from our CI....

mmarchini

Set exit code when commands fail

3

If I run `git node land` on a new machine with nothing configured, I'll get the instructions to set required variables, and then the process will exit with status code...

mmarchini