node-core-utils icon indicating copy to clipboard operation
node-core-utils copied to clipboard

Changes to PR wait time and approval checks

Open mmarchini opened this issue 5 years ago • 1 comments

If https://github.com/nodejs/node/pull/33879 lands the checks should be changed to:

  • Require only one approval by default
    • Recommend (without blocking) to wait for a second approval
  • Drop wait times as requirements (we can still add a suggestion to wait if the PR lands before 48h, but it should return success code and shouldn't block --yes)
  • Check if 48h passed since the wait-for-feedback label was added

As a workaround for now, we can add a .ncurc file to nodejs/node, which will remove the wait time requirements, but handling the more fine grained cases suggested above probably makes more sense.

mmarchini avatar Aug 17 '20 19:08 mmarchini

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

github-actions[bot] avatar Nov 16 '20 00:11 github-actions[bot]

https://github.com/nodejs/node/pull/33879 never landed, we can probably close this.

aduh95 avatar Mar 11 '23 00:03 aduh95