Nicolas Augusto Sassi

Results 19 comments of Nicolas Augusto Sassi

Nice! I think it would be a fun improvement to your already awesome solution. As I was in a rush I did it myself, but I'll paste my code here...

I did not understand how this change is supposed to break the API. Could you please explain better? Your changes seems promising!

#71 added feature to fix the case of amount($). The case of Size (Men's):9.5 is a little more complicated as the tokenizer only considers the first split case (which is...

I would love this feature as well

I'm not really sure how depedencies work on this project, but I tried to add Pebble both to setup.py and to requirements.txt. Hope it fix the problem

@lipoja I fixed most of what was asked. As some changes are still in discussion (like i `find_urls` should have some many args etc...) there are still changes to be...

@lipoja sorry for the delay I'm also kind busy these days. As soon as I have some time I'm gonna implement the changes you've suggested and add more tests. Thank...

@lipoja sure! Life has been crazy and unfortunatelly time is sort... I still hope I can take some time to focus on this project and finish it, but just in...

for reference, this is the hacky way I was refering to: ``` from urlextract import URLExtract from app.infrastructure.analyser.finder import Finder from pebble import concurrent from concurrent.futures import TimeoutError class Hyperlinks(Finder):...

I was studying the code to find a way to achive concurrency in the dns lookup. But I kind got stuck because I seems that there's a cursor in `_complete_url`...