Nick Taylor

Results 259 comments of Nick Taylor

Selenium is too slow and older. We're already using Playwright in the app repo and we're keeping things uniform for tooling. Cypress was an option, but as mentioned, it doesn't...

We currently only support pull requests, but that should be low hanging fruit to support issues as well.

We can probably set a [min-height](https://developer.mozilla.org/en-US/docs/Web/CSS/min-height) on the body in the popup.

@Anush008, consider using `chrome.storage.sync` instead. See https://developer.chrome.com/docs/extensions/reference/storage/#storage-areas. The only caveat is it can't store much, only 100KB but it will perist across all devices and shouldn't get wiped between installs...

The problem is there is a trailing slash when you go to that link, e.g. https://github.com/ahmadbilaldev/langui/, so the only thing after the last slash is nothing which is why you...

Any specific errors in the console?

I haven't seen that error before, but I know that one thing Firefox does not support is manifest v3 which Chrome requires. Firefox currently supports manifest v2 unless that changed...

Looks like Firefox supports manifest v3 as of Firefox 109. See https://extensionworkshop.com/documentation/publish/distribute-manifest-versions/. Just reading some more about it. How are we currently bundling the extension? I looked in the npm...

I'd have to check this, but pre-service worker in Chrome extensions, you had to use a background.js file instead. I wonder if Firefox still requires that even though they are...

This also fixes security updates reported by dependabot, https://github.com/open-sauced/landing-page/security/dependabot?q=is%3Aopen+manifest%3Apackage-lock.json+package%3Anext, but I believe most are only related to app router which this project is not using.