Nicky McCurdy

Results 473 comments of Nicky McCurdy

As far as I understand by looking at the code, `@typescript-eslint/require-await` does check to see if a type is thenable.

This shouldn't be necessary unless you're using a tool with strict dependency requirements like Yarn modern

Some package managers (including Yarn modern) only allow packages to import/require a dependency if it's declared as a dependency in its `package.json`.

@waynevanson leaving this open for now in case you want to add anything.

I assume it's just there for back compatibility. I agree that we probably don't need to keep it around for the next major (as long as we move the one-line...

[They're in DefinitelyTyped.](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/testing-library__jest-dom)

This looks good, but should we leave the breaking changes for a major release or consider this a bug fix?

This should be safe to merge now, as Node 10 and 15 are no longer supported.

**Update:** I've also updated `engines`, so this should be published as a breaking change.

Node 12 support has ended, so I've also removed it. Note that this is still based into `next`, not `main`. Not sure if we still want that.