jest-dom icon indicating copy to clipboard operation
jest-dom copied to clipboard

feat: Drop support for Node 12

Open nickserv opened this issue 4 years ago • 12 comments

What: Don't test with node 10, 12, or 15

Why: Node 10, 12, and 15 reached EOL so let's free up some CI resources.

How: Remove 10, 12, and 15 from node test matrix.

Checklist:

  • ~[ ]~ Documentation added to the docs site
  • [x] Tests
  • ~[ ]~ Typescript definitions updated
  • [x] Ready to be merged

nickserv avatar Jun 12 '21 07:06 nickserv

Codecov Report

Merging #379 (d5313cb) into next (719b35b) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              next      #379   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines          624       630    +6     
  Branches       231       236    +5     
=========================================
+ Hits           624       630    +6     
Impacted Files Coverage Δ
src/to-be-visible.js 100.00% <100.00%> (ø)
src/to-have-focus.js 100.00% <100.00%> (ø)
src/utils.js 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Jun 12 '21 07:06 codecov[bot]

@nickmccurdy what's pending for us to merge this?

gnapse avatar Jul 02 '21 18:07 gnapse

This should be safe to merge now, as Node 10 and 15 are no longer supported.

nickserv avatar Jul 04 '21 12:07 nickserv

Update: I've also updated engines, so this should be published as a breaking change.

nickserv avatar Jul 11 '21 21:07 nickserv

@gnapse are you waiting a little longer to also drop node 12 support? That's coming pretty soon (less than a month, 2022-04-30).

IanVS avatar Apr 04 '22 12:04 IanVS

Node 12 support has ended, so I've also removed it.

Note that this is still based into next, not main. Not sure if we still want that.

nickserv avatar Aug 31 '22 03:08 nickserv

It would be great to merge this soon if possible. Two users have already gotten confused by #473.

nickserv avatar Aug 31 '22 04:08 nickserv

There's also https://github.com/testing-library/jest-dom/pull/438 waiting to be released on the next branch, maybe in a beta?

IanVS avatar Aug 31 '22 04:08 IanVS

I noticed, that's why I didn't change the base to main. Are we waiting on shipping other breaking changes?

nickserv avatar Aug 31 '22 05:08 nickserv

There is https://github.com/testing-library/jest-dom/pull/453 that I can pick back up if there's a chance it will be merged/released. I kind of gave up hope on a breaking release, until now.

IanVS avatar Aug 31 '22 12:08 IanVS

@IanVS Let me know if I can help with anything there. I think we might want another breaking change too: https://github.com/testing-library/jest-dom/pull/472

nickserv avatar Sep 19 '22 10:09 nickserv

@nickmccurdy I've updated https://github.com/testing-library/jest-dom/pull/453 if you'd like to give it a review. Thanks for the nudge.

IanVS avatar Sep 19 '22 13:09 IanVS

I believe this can be closed now, since #511 dropped support for node < 14.

IanVS avatar Aug 22 '23 15:08 IanVS