Nicky McCurdy
Nicky McCurdy
> @jgoz @nickmccurdy confused by the versioning here. There is no v6 release of the core package right? I believe the DefinitelyTyped process is keeping the major and minor the...
We intentionally bundle the types so they don't have to be installed separately with npm. I'd also argue having these types in `devDependencies` is incorrect, since the types are used...
I know, but without this there isn't any mention on how to safely use user-event with CJS, and since this issue doesn't apply to other Testing Library packages, I don't...
I just noticed that the JSDOM options are scoped under a `jsdom` property in `setup`, so there would have to be a change or adapter for that API to fix...
I'm mostly thinking about Jest compatibility, and it doesn't use a `jsdom` property. Can you pass top level options to an environment?
The environment API may not be compatible, but we already document compatibility with the `@jest-environment` comment, so I would prefer to to find a way where we can also be...
Oh sorry, I think I misunderstood the purpose of the key. Is it just there so options other than those in the comments can be passed to the environment? Also...
I seem to have fixed the bug, but I'm not sure if I have the environment option merging right, and things could probably be cleaner and faster in the long...
I think that's a good idea. I want to do something similar for [Testing Library Recorder Extension](https://github.com/testing-library/testing-library-recorder-extension). I've also thought about running Prettier and TypeScript on the emitted output and...
Thanks for the helpful tip, I didn't think about that because I was trying to use tree shaking. Do you think it would make sense to publish with `"sideEffects": false`...