Nicky McCurdy

Results 473 comments of Nicky McCurdy

Answered in DMs, but reposting for historical purposes: > Yea that's intentional. It's because it's currently using JSDOM (the most common environment for Testing Library) which doesn't implement layout. I...

This fixed it for me https://github.com/mozilla/webextension-polyfill/issues/218#issuecomment-584936358

I thought it would be cleaner to just link from the browser APIs to the Node APIs, since they have the same use cases and similar usage. Alternatively, we could...

This is also an issue when using whitespace between types and IIFEs with `no-semi`, for example: ```ts type Status = "pending" | "success" | "failure" (() => {})() ```

> What do you mean? They are all exposed Oh, I think I got confused because I went from the API docs to the browser docs, where only `format` is...

Let's focus on just documenting these APIs for the browser then. If I specifically need `getFileInfo` I'll open an issue later.

`"target": "es6"` doesn't seem to be working but I'm not sure why. ``` Error: 2> ../chrome/node_modules/@puppeteer/replay/lib/main.d.ts(442,5): error TS18028: Private identifiers are only available when targeting ECMAScript 2015 and higher. Error:...

I'd appreciate help with the build errors.

Taking another look, and the errors seem to be unrelated. Anything we can do to unblock this please?

I assume there's no way to release a breaking change in only the types package and still have the versions synced?