Nick Schot

Results 82 comments of Nick Schot

You have some control using the `isOpen` argument which you could combine with some responsive logic in a getter to open it by default on desktop. Locking the menu is...

Sounds like this might be a bug related to this code: https://github.com/nickschot/ember-mobile-menu/blob/83a142c91d588c38a2a9f25768df703dbf8ae7c8/addon/components/mobile-menu-wrapper.js#L212-L217 Could you try & modify those lines into: ``` if (targetMenu) { let activeIsTarget = this.activeMenu === targetMenu;...

cc @nullvoxpopuli

Somewhat relevant to this subject: with empress-blog-hummingbird-template I've noticed that the initial load of a route takes more time. It would be nice to have a feature which blanks the...

We already have a fastboot detection mechanism on the mobile-menu-wrapper component class! I never got the fastboot addon tests working properly (see https://github.com/nickschot/ember-mobile-menu/pull/13 ), which is probably how this incompatibility/bug...

From my local tests we should now be able to go from https://github.com/nickschot/ember-mobile-menu/pull/187 and that should fix this.

It should automatically include the CSS in the vendor bundle in that case. Is that not working? I'd like to move away from SCSS anyway soon and use a PostCSS...

You are right in your findings! ember-mobile-menu's current iteration uses older style javascript based animations with `requestAnimationFrame` (like for example framer-motion, ember-animated also do) which can be interrupted/become janky if...

I'm thinking as we're doing a major release anyway if maybe we should change the behaviour to allow omitting the searchProperty (and then it'd only use the searchKey)? Might make...

So I looked into this a bit and found out a couple of things while tinkering with a ResizeObserver proof of concept for this addon: 1. The native ResizeObserver has...