Nick Schot

Results 82 comments of Nick Schot

Since there's been some activity on this, I've been working on a `mirage-playwright` interceptor in a similar vein to support Mirage use in Playwright tests. Should hopefully be open source...

@mansona could this be merged or what do we need here?

By now it's time to add ember v5 too 😅 edit: oh seems it was, just hasn't been a release yet

> I don't see this on v5.7.0 or v5.5.0, is there something more specific than a new app to recreate it? I just tried again, simply generating a new app...

> So we've been looking at this area recently because of the Embroider upgrades, and I think the ember-cli behaviour is to not generate a test-support.css file if there are...

Confirm that this indeed breaks in v5, shows an assertion.

> Is this still relevant? I'd say yes, this likely relates to [#19497](https://github.com/emberjs/ember.js/issues/19497) and the others mentioned in that thread.

I've observed the same on an app that I was trying to upgrade from embroider@v2 to current v3.2/3.3

This would probably also fix where our a11y is currently lacking (no built-in connection between the toggle button and the menu)

Correct, this addon started when I extracted the implementation from ember-mobile-menu after having issues with ember-gestures/hammerJS. In its current form it's a relatively minimal wrapper built around Pointer Events. The...