nickdevp
nickdevp
Looks like there is a test which is checking for the ShowAll flag. This is the error I'm seeing in the travis-ci logs: assert.False(t, request.ShowAll, "Expected ShowAll to be false")...
The 'ShowAll' flag at the coordinator level seems to only control the evaluation request. The threshold checks are still done at in the 'notifyModule' function if I am reading this...
May have gotten the link wrong above. Please look at the following in core/internal/notifier/coordinator.go: // Only send a notification if the current status is above the module's threshold if int(status.Status)...
Looks like the above failed due to package github.com/goreleaser/nfpm upgrading to go 1.10.
I didn't understand your comment above. May you please clarify? If you feel that this is the wrong approach, let me know if you have an alternative in mind. When...
@toddpalino I am not seeing the behavior you described. If the threshold is set to 1 for notifier N1, but higher for another notifier N2, then N2 will not see...
May I get an update on this PR? I would like to know how we can move forward on this issue.
@toddpalino to mitigate the risk of this PR, perhaps we can add another configuration option to enable this feature? If you have any suggestions, I'd be open to making changes