Nedyalko Dyakov comments

Results 135 comments of


                                            Nedyalko Dyakov

By default loading config from config/webpack.config.js and not app/config/webpack.config.js

@mvrhov This is right, probably a check of `\Symfony\Component\HttpKernel\Kernel::VERSION` should be done? What do you think about that, I can do a fast patch if you agree with this.

By default loading config from config/webpack.config.js and not app/config/webpack.config.js

@mariusbalcytis It shouldn't be a backwards incompatible change as long as people didn't move their config file. We upgraded the bundle and it was searching in `config` on older Symfony...

Support for symfony 4 (and 3.4)

@lexikteam Would you please review this.

The createTime metric is included by the useTime metric

Hello @taytzehao, @hesining this is not related to the client, but to the redisotel, right?

Add redis v7's ExpireAtNX, ExpireAtXX, ExpireAtGT, ExpireAtLT, PExpireNX, PExpireXX, PExpireGT, PExpireLT, PExpireAtNX, PExpireAtXX, PExpireAtGT, PExpireAtLT

@carner Seems this PR was lost a while back. Can you sync with master and see if we can work on a final review of it?

Add redis v7's ExpireAtNX, ExpireAtXX, ExpireAtGT, ExpireAtLT, PExpireNX, PExpireXX, PExpireGT, PExpireLT, PExpireAtNX, PExpireAtXX, PExpireAtGT, PExpireAtLT

Let’s see if we can fix the code. @carner let me know if you need any assistance.

Add redis v7's ExpireAtNX, ExpireAtXX, ExpireAtGT, ExpireAtLT, PExpireNX, PExpireXX, PExpireGT, PExpireLT, PExpireAtNX, PExpireAtXX, PExpireAtGT, PExpireAtLT

@carner after a closer look, we do use another convention of passing options to commands to not blow up the function list by adding a separate function per argument. Check...

Add redis v7's ExpireAtNX, ExpireAtXX, ExpireAtGT, ExpireAtLT, PExpireNX, PExpireXX, PExpireGT, PExpireLT, PExpireAtNX, PExpireAtXX, PExpireAtGT, PExpireAtLT

Hello @carner , do you plan to work on this? I can take over if you don't have time.

Add redis v7's ExpireAtNX, ExpireAtXX, ExpireAtGT, ExpireAtLT, PExpireNX, PExpireXX, PExpireGT, PExpireLT, PExpireAtNX, PExpireAtXX, PExpireAtGT, PExpireAtLT

This PR has been inactive for some time. Closing it, if @carner would like to open a new one, we will gladly review it.

fix(redisotel): fix buggy append in reportPoolStats

Hello @wzy9607, thank you for the contribution. Can you please add a test for that change with the idleAttrs. Interesting bug and nice catch!