Nicholas Blumhardt

Results 929 comments of Nicholas Blumhardt

Thanks for the follow up 👍 Keeping things healthy/maintained over a long time span is definitely an unsolved problem, unfortunately. Being really strategic about feature additions is how this project...

Thanks for posting this, James! I've dug around, I think there's room to optimize this path further (capturing of structured values) but ultimately, it looks like Serilog is just doing...

Recent releases have killed off quite a few allocations; I think we should close this now, and start a fresh round of optimization on the new code. It's an ongoing...

Thanks for the thoughtful write-up. This sounds good, we should have everything in place already on the configuration side to support this. Marking up-for-grabs 👍

Hi! Thanks for the heads-up. Unfortunately, even when the mentioned packages catch up, future changes will result in fragility, here. https://stackoverflow.com/questions/24181557/powershell-config-assembly-redirect has details on how this can be solved, you...

Hi! Wildcards in CSPROJ and NUSPEC files are resolved at build time, not at install time, so this won't have the desired effect, unfortunately. It'd be fine to PR an...

Hello! In your Blazor component, are you able to use `await DisposeAsync()` instead of `Dispose()` on your `Logger`, service collection, or host (whatever is responsible for shutting down Serilog)? If...

Where are you tearing down the service collection, though? It should be possible to async-dispose it, I believe this will use the non-async dispose for components that don't support `IAsyncDisposable`....

Using `DisposeAsync()` on your service collection (or `await app.RunAsync()` in your Program.cs, IIRC) should still call `Dispose()` on services that don't support `IAsyncDisposable`. If you try it and it doesn't...

Ah, that's interesting. Are you somehow creating multiple instances of `PeriodicBatchingSink`? The sink shouldn't be being disposed after every logged event, this normally only happens when the root `Logger` is...