Nicholas Blumhardt

Results 929 comments of Nicholas Blumhardt

I agree that the inclusion of `MinimumLevel.Debug()` here could further muddy the meaning of "debug" in the context of this sink 👍 What if we were to (at worst 😅)...

Hi! Thanks for your message. I don't think it relates to the Serilog.Enrichers.Environment package, though. This one might be best for Stack Overflow's format, where there will be more eyes...

Thanks for raising this. I think the expression should be: ``` Length(@Properties[?].partitions) = 0 ``` But I'm not sure it will work - first because the app sniffs for `{`...

Thanks for sending this and the other five benchmarking PRs, @rafaelsc! Given benchmarks have the same ongoing maintenance costs as other kinds of tests, I think we need to grow...

Hi @rafaelsc, thanks for the reply! I should probably have been clearer, small changes are good, but ideally we should review and discuss only one or two of them at...

@sungam3r thanks for the nudge. We've merged a lot in the last few years; I think most of the remaining ones are stalled or borderline for one reason or another....

Closing this one as stale; thanks again for all the effort on this.

Hi! This is by design - the absence of any settings for Serilog just means that there's no settings to apply. It's quite a common pattern to configure baseline sinks...

Thanks for the note, @NielsUll. Since this can happen on pretty much any code path - loggers that call loggers, sinks that call services that spawn tasks that call loggers,...

Closing as nothing is planned, but appreciate the feedback, thanks 👍