Nicholas Blumhardt

Results 944 comments of Nicholas Blumhardt

Hi @martincostello; there was some progress on this in https://github.com/serilog/serilog/pull/2027, do those changes overlap substantially with this PR? (Guessing yes?)

Thanks for the note. This is a change in ASP.NET Core, rather than Serilog - Serilog has always quoted strings in the default message rendering mode. I'd love to change...

This sounds good to me. The scenario might not warrant the addition of the _Microsoft.Bcl.TimeProvider_ dependency on downlevel platforms, since adopters of `TimeProvider` are more than likely going to be...

RE the API, I suspect using the fluent syntax might avoid some situations where we end up with parallel constructors needed in order to keep passing along a time provider...

Shall we dig in a bit deeper assuming that we'll either conditionally target .NET 8, or conditionally reference the package on earlier platforms? We can get a feel for the...

I think this one's a cool demo but probably not something I'd want to jump into at this point. Happy to keep it on the backburner and discuss post-3.0, though....

Hi Giuseppe! Thanks for dropping us a line; this is on our radar - I am not 100% sure of all the implications, so we may not necessarily be able...

Thanks for sending this! I think this feature would be find if it cleanly slotted in, but as you found in the implementation, it's not completely equivalent to the existing...

@cypressious thanks again for the time spent on this. It's a nicely-implemented PR, but I'm not keen to move forward with it because I don't think we'll ultimately be able...

Hi @cypressious - thanks for the follow-up and sorry about the slow response; my time for this project is currently low. Just to clarify my last comment: > I'm not...