Nicholas Blumhardt

Results 936 comments of Nicholas Blumhardt

This looks good, but its behavior will vary from the reflection version by matching subtypes, while the reflection one is exact. I think it's only a superficial problem - the...

Hi! I might be misunderstanding - raw newlines aren't allowed in JSON strings, so this sounds like it'd be a nasty bug if it was the case. The code that...

Hi! Thanks for digging into this. `ScalarValue.Render()` will (IIRC) lead to `"quoted string"`-style output and non-JSON structured data; a more tactical change might be needed here. Would also be worth...

Thanks for following up! Sorry about the slow reply. Formatting through `ScalarValue` is something of a legacy path, so just making the minimal change here to support `ICustomFormatter` would be...

This seems like a bug, thanks @MrPsi :+1:

Thanks for the note, @matherm-aboehm - we've updated builds of most of our libraries to do this, it seems we haven't made a new release here for a while so...