Nicholas Blumhardt

Results 929 comments of Nicholas Blumhardt

Ah I see; so the title of the ticket should probably be _Use sink via JSON configuration without relying on `TelemetryConfiguration.Active`? Thanks! @dominik-weber @simbaja I don't suppose you (or anyone...

Thanks for the heads-up. I think we should probably remove this example entirely - the only really useful way to configure this sink currently is with a connection string or...

Is anyone able to help out by proposing a solution and then working through a pull request? We're low on maintainer bandwidth so it's unlikely any of the maintainers will...

Thanks for the suggestion! As you guess, I haven't got any experience with shipping .NET CLI tools, but it'd be interesting to explore :-)

Worth remembering that script concatenation means any line numbers reported will have to be offset.

Thanks for the note. This package wraps up and completely internalizes these bits of Serilog, and it would probably be confusing to expose interfaces like `ILogEventEnricher`, but, some cut-down enrichment...

Probably not via `ILogEventEnricher`, but something like `Func` could be used to provide simple enrichment from ambient state, without necessitating exposure of types like `LogEvent`, `LogEventPropertyValue` and so on. Would...

Thanks for the nudge, @danbopes; I'm taking another look at this now.

Thanks for the update @danbopes. `UseSerilog()` still supports .NET's `ILogger`, just in case that helps (`UseSerilog()` is generally a bit more predictable when it comes to levels/filters).

I've kicked off some work on this; I think because it'll be best if accessible via JSON configuration, it's a good time to overhaul how the sink is configured, so...