Nicholas Blumhardt
Nicholas Blumhardt
Seems like a reasonable set of trade-offs 👍
I'm not 100% sure it would actually conflict - if we just add the `IConfiguration root = null` argument to the existing method, the calls would look like: ```csharp //...
I think we might look into enabling `rollOnFileSizeLimit: true` in this package :+1:
Hi @firstyuyu - it should be here I believe: https://github.com/serilog/serilog-extensions-logging-file/blob/dev/src/Serilog.Extensions.Logging.File/Microsoft/Extensions/Logging/FileLoggerExtensions.cs#L146 HTH!
@MikeRavenelle none at this point - a PR would be welcome if anyone is interested in taking a closer look.
Hi! How are you configuring the sink? Do you have `bufferSize` and `blockWhenFull` set? The console sink provides backpressure by default, while the async wrapper does not, so it's also...
Agree with the pro/con analysis. The additional alternative is interesting - it definitely strikes a good balance between the two. It's an improvement over the current syntax, but still does...
The workaround is bearable, but could be surprising. Booleans (if they're supported?) might look less odd: ```json "LiterateConsole": true ``` Parameterless methods still seem like a bit of a trap...
No movement yet! Would be great if someone can write up an RFC-style proposal (perhaps in a new ticket) so that we can nail the design down - from that...
Hi! The best way to get help with this will be to post a question to Stack Overflow tagged `serilog`, including your appsettings.json file, configuration code, and some sample events.