Nabil Freij

Results 791 comments of Nabil Freij

Thanks for the PR @Mubin17, however a change like this needs to be considered as we plan to replace this method in https://github.com/sunpy/sunpy/pull/7760. I think there is a discussion to...

So now https://github.com/sunpy/sunpy/pull/7760 is merged in, I think we add this to the new get_contour method. THe question I have is how should a user switch to the area-based method?...

Thanks @Mubin17, can you add a figure test as well? It would be better to see this tested in figure form as well.

Thanks for the PR @Mubin17, I will close this for now, if you want to work on it again, please reopen it!

Hello @Rachit23110261, there is already a tracking pull request for this issue. I would suggest either helping to finish that or working on another issue.

> hii @wtbarnes I am new to open source and I would love to work on this issue. Is it still open? > Thanks > Regards > Chehak Hello Chehak,...

Thanks for the PR @tien-vo. We will need to give @ayshih some time to review this PR.

Hello @advait-zx, sorry but this isn't going to work. The plan is to remove the "aas-2021-workshop" repository, so a submodule can not work.

Oh wait, there is no submodule. I didn't check the Files Changed tab. Unfortunately, the history of aas-2021-workshop is not here either.

> Is there any branch issue? I am not sure I follow.