Nabil Freij
Nabil Freij
I think we need to work out exactly what we want the example to do, @ayshih do you have some suggestions?
> If I am correct we should just include code snippets demonstrating each coordinate frame and 'how to use them' example, considering definitions for all the parameters is already present...
I think the goal would be add a new keyword that allows to override the `"package="sunpy.data.test",` to be set to another package name. This would allow other packages to use...
> Great! i understood Thank you so much > > Here’s my proposed approach: > > 1. Add a new keyword argument, `package`, to the `get_dummy_map_from_header` function with a default...
I do still have plans, they are still very much alpha at this stage. It's probably gonna take me a while to finish.
So we could wrap it and then provide the output as a Skycoord?
No, I screwed up.
> Apologies for the delay, @nabobalis would you mind taking a look? As I mentioned earlier, the `oldestdeps` is failing. It is creating a warning which is failing the CI:...
> Hey @nabobalis, thanks for the help. Even after adding the `asdf.exceptions.AsdfWarning`, some of the tests are still failing due to `AssertionError`, as the pixel_shape serialization of `gWCS` was [added](https://github.com/sunpy/ndcube/pull/708#:~:text=The%20addition%20of%20pixel_shape%20to%20the%20wcs%20schema%20used%20during%20the%20roundtrip%20serialization)...
We only run devdeps: a oldestdeps build needs to be added.