Mikko Ylinen

Results 291 comments of Mikko Ylinen

> @mythi I am afraid keeping Dockerfiles along may not be sufficient, some demo images have their own entry scripts > (e.g. [dlb-dpdk-demo](https://github.com/intel/intel-device-plugins-for-kubernetes/tree/main/demo/dlb-dpdk-demo)), if we host all files together with...

#1018 is also a good thing to check. There are samples how this is done (e.g., TCS or NFD projects)

> `make set-version` can be used to update version number of charts One thing to note (and fix): our chart `version`s do not change currently. I think these should follow...

@dbolshak thanks for the detailed feedback. I haven't paid too much attention to the script(s) it but looks like they are useful to many. I'll get at least this issue...

> Unfortunately, I didn't notice at the beginning that it requires CPU with Flexible Launch Control support (or it's not mentioned in > docs), so now I am awaiting another...

> I think that the problem is somewhere in NFD. @dbolshak I can see you have: ```"feature.node.kubernetes.io/cpu-sgx.enabled": "true",``` which suggests the cpuid bits are OK and the BIOS has enabled...

> but empty output in `cat /boot/config-5.4.0-109-generic | grep -i sgx` that's the problem. quick fix is to `kubectl edit nodefeaturerule intel-dp-devices` and drop that `kernel.config` match.

> It's not clear why namespace is empty @dbolshak looks like you have everything correct. SgxDevicePlugin is a cluster scoped resource so just deploy it without the namespace (-n sgx-ecdsa-quote).

> I still don't see `sgxdeviceplugin-sample` and sections with events of the following command is empty I don't think we report events for `xDevicePlugins` objects today so empty `Events` is...