system-configuration-rs

system-configuration-rs copied to clipboard

Add High-level API

20

File Changes: ``` system-configuration-sys/src/lib.rs system-configuration-sys/src/network_configuration.rs system-configuration-sys/src/preferences.rs system-configuration/Cargo.toml system-configuration/src/lib.rs system-configuration/src/network_configuration.rs system-configuration/examples/dns.rs ``` --- This change is [](https://reviewable.io/reviews/mullvad/system-configuration-rs/8)

LuoZijun

SCDynamicStoreCopyProxies(NULL) is not covered

1

`SCDynamicStore::get_proxies` always pass self as a reference. There is no way to call `SCDynamicStoreCopyProxies(NULL)`

youknowone

Fix std::net::SocketAddr to libc::sockaddr conversion.

1

This make `SCNetworkReachabilityCreateWithAddressPair` work with any valid pair of addresses, not only `0.0.0.0`. The fixed implementation is mostly taken from [`socket2`](https://github.com/rust-lang/socket2) - - - This change is [](https://reviewable.io/reviews/mullvad/system-configuration-rs/54)

mstyura

Requires Send + Sync + 'static in dynamic store callout

2

Closes #51 I think to the least, Send + 'static is required. But it also depends on whether the callback might be invoked concurrently, which I think is possible, since...

Congyuwang

Add binding to `` which includes functions that returns keys to be used for settings up notifications in SCDynamicStore. - - - This change is [](https://reviewable.io/reviews/mullvad/system-configuration-rs/52)

Congyuwang

Require 'static + Send + Sync for proxy callback info?

1

https://github.com/mullvad/system-configuration-rs/blob/fd43df6f57de954878d824c14c08b57045e46e76/system-configuration/src/dynamic_store.rs#L35-L44

Congyuwang

CFNetwork wrapper needed.

1

Hi @gregoire-mullvad , can you create another crate to wrap `CFNetwork` framework? It's very useful.

ssrlive

We noticed crashes due to missing `null` checks in `dynamic_store.rs`. Additional background: `SCDynamicStoreCreate` / `SCDynamicStoreCreateWithOptions` can return `null`. The returned value is currently passed to `wrap_under_create_rule` without a `null` check,...

aw-cf

Fixes compilation errors when compiling on non-MacOS systems. Now causes compilation to be a no-op. Fixes [Issue #62 ](https://github.com/mullvad/system-configuration-rs/issues/62) - - - This change is [](https://reviewable.io/reviews/mullvad/system-configuration-rs/63)

nate-fe2o3

`sockaddr_in` does not have this field (Rust 1.81 on Linux)

2

I am getting the following build error from `system_configuration` v0.6.1 when building on Linux: ``` ERROR: /root/.cache/bazel/_bazel_root/f1dda70852d9c97abf4f8f9fda6b2822/external/rules_rust~~crate~crates_index__system-configuration-0.6.1/BUILD.bazel:16:13: Compiling Rust rlib system_configuration v0.6.1 (7 files) failed: (Exit 1): process_wrapper failed: error...

tgsmith61591