system-configuration-rs icon indicating copy to clipboard operation
system-configuration-rs copied to clipboard

Published 20 hours ago • verified publisher icon mullvad

Fix std::net::SocketAddr to libc::sockaddr conversion.

Open mstyura opened this issue 1 year ago • 1 comments

This make SCNetworkReachabilityCreateWithAddressPair work with any valid pair of addresses, not only 0.0.0.0. The fixed implementation is mostly taken from socket2

This change is Reviewable

mstyura avatar Jul 31 '24 21:07 mstyura

@dlon could you please review this PR, thanks a lot in advance!

mstyura avatar Aug 01 '24 07:08 mstyura

@faern could you please take a look at this PR and merge if you are ok with changes? Thanks a lot in advance, Yury.

mstyura avatar Aug 12 '24 08:08 mstyura

Hi. Sorry for the slow reply. It's still vacation period in Sweden and many developers are off. We'll get back to you once we have the manpower to handle third party PRs :) Thanks for contributing a fix!

faern avatar Aug 13 '24 09:08 faern

Ok, no problem at all, have a great vacation!

mstyura avatar Aug 13 '24 10:08 mstyura

This fix has now been published, as part of 0.6.1: https://crates.io/crates/system-configuration/0.6.1

faern avatar Aug 22 '24 13:08 faern