Matthew Ryan
Matthew Ryan
> Could you share with me your opinion on bn254 issue and what should we do next? No opinion yet, we'll want to figure out the performance issues before thinking...
Running tests on the Mina branch [here](https://github.com/MinaProtocol/mina/tree/feature/update_curves_to_arkworks_042-compatible), this seems to make proving 2x slower. We should *not* merge this.
> ``` > if you want :) > ``` I don't
Running tests on the Mina branch [here](https://github.com/MinaProtocol/mina/tree/feature/update_curves_to_arkworks_042-compatible), this seems to make proving 2x slower. We should *not* merge this. *Edit to add data:* Timings before this PR: ``` $ _build/default/src/app/cli/src/mina.exe...
When all of the instructions are in, we shouldn't even need a wrapper. The end of the each function can do ```rust env.set_instruction_pointer(next_instruction_pointer.clone()); env.set_next_instruction_pointer(next_instruction_pointer + Env::constant(4)); ``` and then any...
To add some flavour to the original issue: the goal here is to support looking up an account that we know has been proven in a certain block (by using...
!ci-build-me
!approved-for-mainnet
Closing as stale. If you're still seeing this issue on 3.0.0 or later, please open a new issue.
On reflection, it's probably best to put the coverage logic in the cleanup logic in `test_executive.ml`, like: ```diff diff --git a/src/app/test_executive/test_executive.ml b/src/app/test_executive/test_executive.ml index 744797807d..5b8054e48e 100644 --- a/src/app/test_executive/test_executive.ml +++ b/src/app/test_executive/test_executive.ml @@...