Matthias Endler

Results 748 comments of Matthias Endler
trafficstars

Why was that closed? I'd still say it would be interesting to know the reason why it is not working. Perhaps someone wants to pick this up in the future?

bat uses splice? That's news to me. I couldn't find any hint in the source code, only two issues, one closed and the other open but stalled. * https://github.com/sharkdp/bat/issues/1112 *...

I looked through the [5.9 changelog](https://cdn.kernel.org/pub/linux/kernel/v5.x/ChangeLog-5.9) and could only find [this patch](https://lore.kernel.org/linux-fsdevel/bfa88b5ad6f069b2b679316b9e495a970130416c.1601567868.git.josef@toxicpanda.com/), which describes a deadlock in combination with splice. Can't find much else. Maybe somebody with more kernel experience...

So does that mean we have to ask on the Linux Kernel mailing list if they can add back support for splice for our use-case? 😅

I doubt they would if it's not on their roadmap already, which probably would mean this project is dead. 😆

Not gonna lie, it's looking pretty bleak for this project. Newer kernels changed the behavior of splice and that broke our use-case. 😕 Unless we find a workaround (or convince...

To know if this change improves performance, it would be nice to have automated benchmarks. @vbrandl is working on the travis setup. Once he's done, we could add pv to...

Hey @ArniDagur, this PR was lying dormant for a while. Thanks for the ping. I haven't gotten around to testing it, but if you like you could provide some benchmark...

That's one option. We just need to keep in mind that this only supports Linux Kernels 4.5 and up. So that would be the March 2016 release and later. I...

As a first step, shall we increase the [buffer size](https://github.com/mre/fcat/blob/master/src/main.rs#L19) to 65536 bytes as suggested by [the comment on Reddit](https://www.reddit.com/r/rust/comments/93fbrj/fascat_a_faster_cat_implementation_using_splice/e3dl0f3/) @vbrandl ? Don't see any downside here. 🤔