Matthias Endler

Results 724 comments of Matthias Endler
trafficstars

Thanks for your PRs @greyblake. For sure sounds like a nice idea to try. I'm gonna run the benchmarks, but what I would really love to do is running a...

So I ran the benchmarks on my machine and the values of this branch are very close to the master branch, well within the standard deviation. That means I can't...

Pretty similar to what I saw in my benchmarks. You can control the number of iterations and rounds with the following parameters: ``` pipenv run pytest benchmarks --benchmark-min-rounds=BENCHMARK_MIN_ROUNDS --benchmark-warmup-iterations=NUM ```...

I'm in the process of setting up a machine for profiling. Have a dedicated Linux box now for that purpose. If anybody has time to profile the code before me,...

@wdv4758h, could you merge the master into this branch? Maybe that fixes a few more tests now. I'd love to get this merged. 😉 🍷

FYI: Working on the fixes over at #54 in case anybody wants to chime in. 😉

@konstin thanks to the fix for https://github.com/PyO3/pyo3/issues/177 I was able to add our own `JSONDecodeError` to hyperjson (yay!). This fixes a few unit tests and that makes me very happy....

Oh yeah. I think the reason is that I never got around to benchmarking the change myself. If there is no noticeable perf-improvement I'd opt for keeping the BTreeMap impl...

More benchmark data: * [Benchmark data](https://users.rust-lang.org/t/serde-and-serde-json-1-0-0-released/10466/3) * [Comments on benchmark data](https://www.reddit.com/r/rust/comments/6albr0/serde_compared_to_the_fastest_c_json_library/) * [Another benchmark](https://github.com/serde-rs/json-benchmark) * [Some ultrajson benchmarks](https://pypi.python.org/pypi/ujson)

Nice find @ethanhs. One would have to check, which cases we already cover and add the remaining ones to our benchmark. If there's anything in particular we aren't testing yet,...