Matthias Endler

Results 885 comments of Matthias Endler

@robinst [suggested](https://github.com/robinst/linkify/issues/68#issuecomment-1975127048) using a CSV parser and pass individual cells to linkify. This has a few advantages: - Clear separation of concerns between the tools. - Doesn't require a (potentially...

That's a great idea! What counts as an error response? For connection errors, both methods shouldn't work. Currently, errors are defined as https://github.com/lycheeverse/lychee/blob/a8e9f04d8c6ed7b4e4be32cab77b61e6d42fb2fd/lychee-lib/src/types/status.rs#L159-L164 where https://github.com/lycheeverse/lychee/blob/a8e9f04d8c6ed7b4e4be32cab77b61e6d42fb2fd/lychee-lib/src/types/status.rs#L22-L43 and https://github.com/lycheeverse/lychee/blob/a8e9f04d8c6ed7b4e4be32cab77b61e6d42fb2fd/lychee-lib/src/types/error.rs#L12-L148 Does that include...

@sanmai-NL ping, in case you have any thoughts on this.

Hey @xlai89, thanks for considering to work on this! That would be great. 👍 The changes would be quite similar to https://github.com/lycheeverse/lychee/pull/1187. Perhaps you want to tackle that one first?...

Yeah, good idea. Some of it is already supported. We have - `--max-redirects`, which defaults to 5 - `--max-retries`, which defaults to 3 We are missing - `--retry-on-host-error`: I'm undecided...

Interesting use-case

I'm not against adding support for that, but I will not add it myself. I'd appreciate a pull request, though. The way I currently think about it would be to...

Good progress. I don't know what we could do with TLS 1.3. Maybe we print an error with nativetls and support it with rustls?

I like the `modify_headers` syntax you linked to. We could add something like this. Just to clarify, this doesn't require a proxy, but rather a way to pass these headers...

Yes, we can add an additional example. The regex matches on the full URL including the scheme in order to support cases like this. Perhaps we find a way to...