Matthias Endler

Results 884 comments of Matthias Endler

I wouldn't mind. Sounds like a reasonable idea. @thomas-zahner @Arteiii what do you think?

Took a stab at it in #292.

Okay, the plan is: 1. test the changes thoroughly by using the tag like so ```yaml - name: Link Checker id: lychee uses: lycheeverse/lychee-action@cache with: fail: false ``` 2. merge...

Glad you're tackling this. > 1. I think it makes sense to show a Redirects section in the end just as we currently do with Suggestions. But I think we...

I think we should probably separate redirect tracking from the existing `--suggest` flag, though I'm finding it tricky to land on a definitive answer here. The core issue seems to...

> What do you think about this? I'm also okay with your proposal of a new flag called `--redirects`. But maybe we want to always show the redirects, only depending...

> Yes I agree with that. That was basically my initial proposal, maybe you misunderstood me. Yes, probably. Sorry about that.

Makes sense, yeah; `reqwest::redirect::Policy` is pretty nice. The draft looks good. Perhaps we would like to introduce an actual type for tracking the redirects? How about this? ```rust use std::{collections::HashMap,...

Fully agree. Great explanation. 👌

> `[301] http://google.com/jobs | Rejected status code (this depends on your "accept" configuration): Moved Permanently` This error message sounds a bit misleading to me given that changing the `accept` configuration...