Matthias Endler

Results 854 comments of Matthias Endler

https://www.behance.net/gallery/89117181/Ferris-the-professional

Hey that's a good feature to have. I checked the code (https://github.com/gaurav-nelson/github-action-markdown-link-check/blob/master/entrypoint.sh#L155) and it doesn't seem too hard to port.

Just to clarify, the diff checking would exactly work like in [github-action-markdown-link-check](https://github.com/gaurav-nelson/github-action-markdown-link-check#check-only-modified-files-in-a-pull-request) because we'd use the same code. So if that works for you, we should be all set. 😄

Yes, I still plan to add that feature by porting over the code from [github-action-markdown-link-check](https://github.com/gaurav-nelson/github-action-markdown-link-check#check-only-modified-files-in-a-pull-request).

Thanks for the heads-up @polarathene. I wonder if anyone tried do something like this: ```yaml jobs: build: runs-on: ubuntu-latest name: Test changed-files steps: - uses: actions/checkout@v3 with: fetch-depth: 0 #...

Thanks for the thorough writeup. To avoid issues with spaces, have you tried terminating the inputs with a NUL terminator? https://github.com/BurntSushi/ripgrep/issues/273#issuecomment-265506073

Since this is a breaking change, a new major version would have to be released.

If someone wants to give this a try, there are Github actions like these that we could use: https://github.com/marketplace/actions/slack-notify. I'd prefer that over bundling the Slack integration into lychee-action, because...

Sounds like you found https://github.com/lycheeverse/lychee-action#alternative-approach already. But just in general, the thought process was that lychee was used as a step within a bigger "linting" pipeline and we didn't want...

I agree. If there are no objections I'm all for changing it. @lycheeverse/contrib fyi