Matthias Endler

Results 866 comments of Matthias Endler

Oh. Would you like to create a PR for that?

Oh well. Wonder how we can fix it.

We could introduce a breaking change with a new version but yeah, it's not ideal. Alternatively, we could check if version is nightly and avoid prepending the `v`.

@dscho fixed it. @osslate, please try again. 😊 If it doesn't work as expected, please reopen.

Hello @zapashcanon, thanks for your contribution. The tool looks great, however the `README.md` file is auto-generated from the files in `data/tools`. Can you please go ahead and create a new...

Nope, it doesn't. It's a `PathBuf`: https://github.com/lycheeverse/lychee/blob/a11d51549b3d1b9fd1be2247bee1588fc01a751a/lychee-bin/src/options.rs#L341 I thought it did, but no dice. Although we could certainly *make* it accept a regex and we probably should. Would you like...

> I just spent an hour trying to figure our so many different permutations of regex/glob/etc to try and get it to work. Sorry about that. Thanks for fixing the...

Wouldn't this update the lychee version even for users who've pinned the lychee-action? This could potentially introduce breaking changes unexpectedly. I'm not entirely sure how GitHub Actions handle this interaction...

Yeah, @Arteiii did a great job there. Glad that works for you. Closing. 😊