Morgante Pell

Results 259 comments of Morgante Pell
trafficstars

I would consider accepting a pull request making these optional.

> I see the main module has contribution documentation, and it should start from autogen . Does this apply to NEG module? Yes. > I'm checking architecture how it's built...

For root modules, the general recommendation and best practice is to pin to a specific major version. Examples should follow this best practice, so I'm not comfortable with updating this...

We also need tests covering the various scenarios documented [here](https://github.com/terraform-google-modules/terraform-google-project-factory/pull/94#issuecomment-454571096).

Here's how I suggest we tackle this: - In the [test-org](https://github.com/GoogleCloudPlatform/cloud-foundation-toolkit/tree/master/infra/terraform/test-org), create a new folder+project for project-factory that includes creating a service account and applies the correct permissions, roughly mirroring...

Sure, we could have a separate folder which behaves similarly but is only used for CI.

@paulpalamarchuk These requests need to be made on the provider not Terraform core: https://github.com/terraform-providers/terraform-provider-google

We do not currently plan to support in-cluster install and recommend migrating to the Google managed control plane.

Is this consistently reproducible? Unfortunately I don't see an easy fix for this if it's a race condition.