Morgante Pell

Results 265 comments of Morgante Pell
trafficstars

Thanks, probably not adding a bounty for now though.

@varshith257 I would be very surprised if this is sufficient to fix the issue. Please make sure you have added the test case from the issue and make sure all...

Are you using Grit outside a terminal shell? I regularly use globs, but the shell has built-in expansion support. Ex. I just ran: ``` $ grit apply '`console.log`' **/*.test.js ```

Unfortunately we can't control how bash handles directory traversal. We might consider our own glob matching in the future but I also want to avoid too much scope creep. For...

> Thanks a ton for the work you do! The DSL is super interesting, albeit/because it is a challenge to wrap my head around. Love it being open source! Thank...

It's probably sufficient to add a `pattern_files` array in `.grit/grit.yaml` to list additional files in the repo that should be parsed as testable patterns. For example: ``` version: 0.2.0 patterns:...

https://github.com/getgrit/gritql/pull/398

> I still don't grok the patching the grammar business, e.g. when to use field vs bare choice, and also I'm not yet confident that when I change cpp-metavariable-grammar.js the...

> Thanks, this must be the issue. I wasn’t running that script. Please do read the documentation / contributing guide thoroughly. It covers important details.