Cameron Moore

Results 147 comments of Cameron Moore

@alexlafreniere, what do you expect to happen when the input contains an invalid semver string? I'll throw out a proposal for discussion: The existing function signature for `sort` is: ```...

Yes, I forgot to mention the workaround is "don't do that." 😀

Can you provide the full headers for the request?

Makes requests to that host with HTTPS. If you're already doing that, then I don't understand what the problem is.

HTTP/2 works out of the box with Go 1.16+. Prior to that you need to [use a custom transport](https://pkg.go.dev/github.com/go-resty/resty/v2#Client.SetTransport) from [`golang.org/x/net/http2`](https://pkg.go.dev/golang.org/x/net/http2).

@yjhmelody commented [here](https://github.com/go-resty/resty/pull/392#issuecomment-758527480) that option 2 (retry forever) is preferred. I tend to agree. Normally, a `-1` in this scenario means "no limit."

See previous discussion: https://github.com/go-resty/resty/discussions/467#discussioncomment-1569756

Seems simple enough. We obviously don't have tests around this code. Do you have time to add tests?

I'm pretty sure `Request.URL` is purposely not set until a request is finally executed. In your example, that happens with `req.Get`.