resty icon indicating copy to clipboard operation
resty copied to clipboard

Allow multipart/form-data in PATCH request

Open sabandi opened this issue 3 years ago • 6 comments

sabandi avatar Apr 15 '22 09:04 sabandi

Codecov Report

Merging #536 (2f4e675) into master (313f419) will decrease coverage by 0.31%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #536      +/-   ##
==========================================
- Coverage   96.69%   96.39%   -0.31%     
==========================================
  Files          10       10              
  Lines        1330     1330              
==========================================
- Hits         1286     1282       -4     
- Misses         26       30       +4     
  Partials       18       18              
Impacted Files Coverage Δ
middleware.go 92.85% <100.00%> (ø)
request.go 96.35% <0.00%> (-1.46%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Apr 16 '22 18:04 codecov[bot]

@jeevatkm could you please review this change.

sabandi avatar Apr 25 '22 07:04 sabandi

Seems simple enough. We obviously don't have tests around this code. Do you have time to add tests?

moorereason avatar Apr 25 '22 17:04 moorereason

Seems simple enough. We obviously don't have tests around this code. Do you have time to add tests?

@moorereason Added a simple test as per your suggestion. Please review.

sabandi avatar Apr 25 '22 17:04 sabandi

Test result.

~/Desktop/ patch-1 ❯ go test  -run ^TestMultiPartUploadFileViaPatch$ ./...
ok      github.com/go-resty/resty/v2    0.202s

sabandi avatar Apr 25 '22 18:04 sabandi

@moorereason just checking in to see if you got a chance to review this.

sabandi avatar Apr 29 '22 07:04 sabandi