Cameron Moore

Results 147 comments of Cameron Moore

@adnanh, This PR is a preview of something I've been slowly whittling on. It all started by wanting to fix #393. I needed to be able to access the `http.Server`...

Isn't that the job of the Debian package maintainers? They usually put that kind of information in /usr/share/doc/webhook/README.Debian.

I assume you mean exposing a metrics HTTP endpoint in webhook for prometheus to scrape. I haven't looked into it, but I've only toyed with prometheus in the past. Not...

@bbarclay, thanks for the feedback. If you have specific questions about how to use `webhook`, use the [discussions area](https://github.com/adnanh/webhook/discussions) for that.

webhook doesn't currently support that. You'll have to do your filtering in nginx for now.

**Proposed Solution** Add a new `cidr` match type and deprecate the `ip-whitelist` match type. ``` "match": { "type": "cidr", "value": "1.2.3.0/24", "parameter": { "source": "request", "name": "remote-addr" } } ```...

Seems like you should validate IPs at the proxy server instead of within webhook. But if anyone's interested in implementing this, see https://github.com/armon/go-proxyproto.

> Isn't YAML basically a superset of JSON... For the record, YAML is not a superset of JSON.

@delanym, we don't manage the snap package. Contact the package maintainers.

@adnanh, do you maintain the snap package? If so, I was unaware of it.