Moad Zardab

Results 11 comments of Moad Zardab

Are you writing all of your blocks to the same bucket? You cannot run multiple Thanos compactors agains the same block stream (https://thanos.io/tip/components/compact.md/#warning-only-one-instance-of-compactor-may-run-against-a-single-stream-of-blocks-in-a-single-object-storage) The error you're getting is because multiple...

What does your `--selector.relabel-config` look like?

> * Are S/M/L configurable? (probably they should) Yes. I'm contemplating what this configuration would look like. Perhaps passing in arrays for each of the 'histogram partitions' (i.e. the labels...

Initial proposal here @bwplotka https://github.com/thanos-io/thanos/pull/4932 with some caveats around what the metric will actually capture (specifically just the select phase of a query in `thanos/store/proxy` which precludes any processing)

@ianbillett that would be very useful, but I wonder if it would encourage improper usage of this metric. * Single Responsibility Principle; this metric tracks query performance relative to query...

@yeya24, @matej-g any chance we could get a review to try to unblock `go-grpc-middleware` upgrade?

Hey @patilsuraj767 thanks for raising this PR! I have a few potential contentions with this approach wrt how it impacts observatorium-api's statelessness: Generally obs-api is completely stateless authn/authz proxy. My...

> I have doubt regarding {tenant_id}/metrics/api/v1/blocks/mark?block-id={SOME_BLOCK_ID} API. How do we mark a block 'ready for querying' OR 'not ready for querying'? We deploy Thanos behind Observatorium (https://github.com/observatorium/api) where we manage...

> Thanks @moadz Got your point. Regarding Thanos Compactor, Do you think thanos compactor can cause any issue here? I mean time between the block is uploaded and the mark...