Marija Najdova

Results 336 comments of Marija Najdova

@subodha we had a similar setup, but needed to revert it, see https://github.com/mui-org/material-ui/pull/27917 as an example

I've updated https://github.com/mui-org/material-ui/pull/29873 to also add `withConfig` internally on all MUI components, but still, it doesn't solve the issue. I will extract the changes that are necessary for the plugin...

> All in all, it seems the current solution involves a lot of hacks and workarounds that for me just aren't worth the mui v5 improvements. Even with the hacks,...

@kdelmonte we haven't find any solution to this problem yet, and it looks like there is no response to: - https://github.com/styled-components/babel-plugin-styled-components/pull/364 - https://github.com/styled-components/babel-plugin-styled-components/pull/365 My honest proposal would be to switch...

Sure thing @kdelmonte, and sorry for the delayed answer.

@rbong I haven't been looking into this for quite some time. I can try to refresh my view on it next week and provide more feedback if I can. Thanks...

> It seems to me that the System could be a better place for this as it's a utility to help styling components. CC @mnajdova @michaldudak I would argue that...

The goal of adding this `aria-hidden` is to indicate that the page is not interactive until the drawer is opened. Isn't this improving the a11y experience?

@sforehand they are siblings - ![image](https://user-images.githubusercontent.com/4512430/181259704-3b495696-0671-45fc-961f-e590d467ec5b.png)

> I think the issue here is the parent receives a aria-hidden but the drawer is child of the div so it presents as a problem. See in https://github.com/mui/material-ui/issues/33245#issuecomment-1196768921, this...