Chris Ewald
Chris Ewald
Thanks so much for the quick reply @jamonholmgren! For what it is worth, I attempted to do a naive upgrade to 0.69.1 starting by running `npx react-native upgrade 0.69.1` It...
Hi All, Quick message for anyone who comes across this - I successfully switched over to using VSCode-neovim. Much more performant! and surprising few rough edges. I created a basic...
Great feedback. I'll fix this up.
Hi @dewski - I updated this branch according to your feedback. I changed the the name of the cookie test from `peek_enabled` to `peek_bar_visible`: https://github.com/peek/peek/pull/79/files#diff-5fa9351cd8e19ee995f9f3c600861393R14 in response to this comment:...
> Could you clarify what you mentioned here? Sure. `peek_enabled` is meant to be overridden in descendant controllers. From the readme: ``` ruby class ApplicationController < ActionController::Base def peek_enabled? current_user.staff?...
`peek_enabled?` would need to look like this if we were to reuse it: ``` ruby class ApplicationController < ActionController::Base def peek_enabled? return false unless peek_bar_visible? current_user.staff? end end ```
Hi @dewski - Hoping we can resolve this soon. What are your thoughts on https://github.com/peek/peek/pull/79#issuecomment-153131408 ?
> @mkcode did you mean you want me to create a new PR that asking merging from delete-repos-cleanup to master branch? Thanks. If it is possible, that would be great!
@PeterDaveHello - With GitHub Pull Requests - you can add more commits to this existing PR. Really handy! Do the following: ``` shell cd teachers_pet # in this repo dir...
@PeterDaveHello - I added to this PR in #126. Can you please take a look at #126 and create a new PR targeting the `delete-repos-cleanup` branch? Thanks!