Matthias J. Sax

Results 147 comments of Matthias J. Sax

@fonsdant There is merge conflicts -- can you rebase to latest `trunk`?

Merged to `trunk`. Thanks for the PR! One down. Three to go. :) Looking forward to your update of https://github.com/apache/kafka/pull/17245

Just wondering if we should put a workaround to fix Eclipse? I tend to day rather no.

Seems this test is full of race conditions? -- But it seems there is no easy way to control it fully... Not sure if using more input records by itself...

> Given that the goal of the test is to prove onRestoreSuspended get executed, I've removed the race condition for onRestoreSuspended and now check at the end of the test...

There is two overloads. The old one, using `org.apache.kafka.streams.processor.ProcessorSupplier` ``` org.apache.kafka.streams.Topology#addProcessor(java.lang.String, org.apache.kafka.streams.processor.ProcessorSupplier, java.lang.String...) ``` And the new one using `org.apache.kafka.streams.processor.api.ProcessorSupplier` ``` org.apache.kafka.streams.Topology#addProcessor(java.lang.String, org.apache.kafka.streams.processor.ProcessorSupplier, java.lang.String...) ``` Note the different package names....

The build has checkstyle errors: ``` > Task :streams:checkstyleMain --   | 2993 | 09:39:12 AM | [ant:checkstyle] [ERROR] /home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-16791/streams/src/main/java/org/apache/kafka/streams/processor/ProcessorContext.java:23:8: Unused import - org.apache.kafka.streams.Topology. [UnusedImports]   | 2994 | 09:39:12 AM |...

Yes, check the readme for gradle commands: https://github.com/apache/kafka